[ https://issues.apache.org/jira/browse/KAFKA-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408067#comment-15408067 ]
Ismael Juma commented on KAFKA-3989: ------------------------------------ Is the former in the `buildscript` section? If so, that seems fine. We do the same for other build plugins. Out of curiosity, what's the advantage of using the shadow plugin instead of jmh-gradle? > Add JMH module for Benchmarks > ----------------------------- > > Key: KAFKA-3989 > URL: https://issues.apache.org/jira/browse/KAFKA-3989 > Project: Kafka > Issue Type: Improvement > Reporter: Bill Bejeck > Assignee: Bill Bejeck > Fix For: 0.10.1.0 > > > JMH is a Java harness for building, running, and analyzing benchmarks written > in Java or JVM languages. To run properly JMH needs to be in it's own > module. This task will also investigate using the jmh -gradle pluging > [https://github.com/melix/jmh-gradle-plugin] which enables the use of JMH > from gradle. This is related to > [https://issues.apache.org/jira/browse/KAFKA-3973] -- This message was sent by Atlassian JIRA (v6.3.4#6332)