[
https://issues.apache.org/jira/browse/KAFKA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399367#comment-15399367
]
ASF GitHub Bot commented on KAFKA-3946:
---------------------------------------
GitHub user mimaison opened a pull request:
https://github.com/apache/kafka/pull/1680
KAFKA-3946: Protocol guide should say that Produce request acks can o…
…nly be 0, 1, or -1
Rephrased the documentation string for the Produce request
Updated the acks configuration docs to state that -1, 0, and 1 are the only
allowed values
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mimaison/kafka KAFKA-3946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1680
----
commit afa886cf387b3b184f127c2b9b62e480e25d6730
Author: Mickael Maison <[email protected]>
Date: 2016-07-29T10:13:34Z
KAFKA-3946: Protocol guide should say that Produce request acks can only be
0, 1, or -1
Rephrased the documentation string for the Produce request
Updated the acks configuration docs to state that -1, 0, and 1 are the only
allowed values
----
> Protocol guide should say that Produce request acks can only be 0, 1, or -1
> ---------------------------------------------------------------------------
>
> Key: KAFKA-3946
> URL: https://issues.apache.org/jira/browse/KAFKA-3946
> Project: Kafka
> Issue Type: Bug
> Reporter: James Cheng
> Assignee: Mickael Maison
> Priority: Minor
>
> The protocol guide at http://kafka.apache.org/protocol.html#protocol_messages
> says that for Produce requests, acks means:
> The number of nodes that should replicate the produce before returning. -1
> indicates the full ISR.
> This seems to imply that you can specify values of 2,3,4, etc.
> It would be clearer if the description was more explicit. It should say that
> the only valid values are 0, 1, and -1, per the code at
> https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L382-L384
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
