[ 
https://issues.apache.org/jira/browse/KAFKA-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388593#comment-15388593
 ] 

ASF GitHub Bot commented on KAFKA-3929:
---------------------------------------

GitHub user dguy opened a pull request:

    https://github.com/apache/kafka/pull/1649

    KAFKA-3929: Add prefix for underlying clients configs in StreamConfig

    Add prefixes for consumer and producer configs to StreamsConfig, but be 
backward compatible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dguy/kafka kafka-3929

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1649
    
----
commit 67f5e22eed250f65535bb1c93cf17b55324ddd0f
Author: Damian Guy <damian....@gmail.com>
Date:   2016-07-21T23:14:12Z

    enable prefixes for consumer and producer configs in streams config

----


> Add prefix for underlying clients configs in StreamConfig
> ---------------------------------------------------------
>
>                 Key: KAFKA-3929
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3929
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Damian Guy
>              Labels: api
>
> There are a couple of configs that have the same name for producer / consumer 
> configs, e.g. take a look at {{CommonClientConfigs}}, and also for producer / 
> consumer interceptors there are commonly named configs as well.
> This is semi-related to KAFKA-3740 since we need to add "sub-class" configs 
> for RocksDB as well, and we'd better have some prefix mechanism for such 
> hierarchical configs in general.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to