[
https://issues.apache.org/jira/browse/KAFKA-3740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385061#comment-15385061
]
ASF GitHub Bot commented on KAFKA-3740:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/1640
KAFKA-3740: Enable configuration of RocksDBStores
Add new config StreamsConfig.ROCKSDB_CONFIG_SETTER_CLASS_CONFIG to enable
advanced
RocksDB users to override default RocksDB configuration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-3740-listener
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1640
----
commit 8c0f586336731f19ca472e74aacccdc86417a064
Author: Damian Guy <damian....@gmail.com>
Date: 2016-07-19T22:57:08Z
Add new config StreamsConfig.ROCKSDB_CONFIG_SETTER_CLASS_CONFIG to enable
advanced
RocksDB users to override default RocksDB configuration
----
> Enable configuration of RocksDBStores
> -------------------------------------
>
> Key: KAFKA-3740
> URL: https://issues.apache.org/jira/browse/KAFKA-3740
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Reporter: Guozhang Wang
> Assignee: Damian Guy
> Labels: api, newbie
>
> Today most of the rocksDB configs are hard written inside {{RocksDBStore}},
> or the default values are directly used. We need to make them configurable
> for advanced users. For example, some default values may not work perfectly
> for some scenarios:
> https://github.com/HenryCaiHaiying/kafka/commit/ccc4e25b110cd33eea47b40a2f6bf17ba0924576
>
> One way of doing that is to introduce a "RocksDBStoreConfigs" objects similar
> to "StreamsConfig", which defines all related rocksDB options configs, that
> can be passed as key-value pairs to "StreamsConfig".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
