Thanks Damian, the KIP wiki looks good to me. One minor comment on the "Compatibility, Deprecation, and Migration Plan" section: we probably also want to mentions that since we need to handle concurrent access with the queryable state support, this may incur slight overhead on the streams applications while query is on-going, and we will quantize the overhead in our benchmarks.
On Mon, Jul 4, 2016 at 12:44 AM, Damian Guy <damian....@gmail.com> wrote: > Thanks Jay - i've updated the KIP accordingly. > > Thanks, > Damian > > On Fri, 1 Jul 2016 at 16:19 Jay Kreps <j...@confluent.io> wrote: > > > We have not used the "get" prefex in methods, like getXyz(), elsewhere in > > our java code, instead sticking with the scala style methods like xyz(). > > It'd be good to change those. > > > > -Jay > > > > On Fri, Jul 1, 2016 at 4:09 AM, Damian Guy <damian....@gmail.com> wrote: > > > > > Hi, > > > > > > We've made some modifications to the KIP. The "Discovery" API has been > > > changed > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-67%3A+Queryable+state+for+Kafka+Streams#KIP-67:QueryablestateforKafkaStreams-Step2inproposal:globaldiscoveryofstatestores > > > > > > Please take a look. > > > > > > Many thanks, > > > Damian > > > > > > On Tue, 28 Jun 2016 at 09:34 Damian Guy <damian....@gmail.com> wrote: > > > > > > > Hi, > > > > > > > > We have created KIP 67: Queryable state for Kafka Streams` > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-67%3A+Queryable+state+for+Kafka+Streams > > > > > > > > Please take a look. Feedback is appreciated. > > > > > > > > Thank you > > > > > > > > > > -- -- Guozhang
