[
https://issues.apache.org/jira/browse/KAFKA-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364023#comment-15364023
]
ASF GitHub Bot commented on KAFKA-3836:
---------------------------------------
GitHub user jeyhunkarimov opened a pull request:
https://github.com/apache/kafka/pull/1591
KAFKA-3836: KStreamReduce and KTableReduce should not pass nulls to
Deserializers
Minor changes to check null changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeyhunkarimov/kafka KAFKA-3836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit ac421c30f698153a5733ffb71e677633d1edbe9c
Author: Jeyhun Karimov <je.kari...@gmail.com>
Date: 2016-07-06T09:05:13Z
KAFKA-3836 null checks v2
----
> KStreamReduce and KTableReduce should not pass nulls to Deserializers
> ---------------------------------------------------------------------
>
> Key: KAFKA-3836
> URL: https://issues.apache.org/jira/browse/KAFKA-3836
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 0.10.0.0
> Reporter: Avi Flax
> Assignee: Jeyhun Karimov
> Priority: Trivial
> Labels: architecture
>
> As per [this
> discussion|http://mail-archives.apache.org/mod_mbox/kafka-users/201606.mbox/%3ccahwhrru29jw4jgvhsijwbvlzb3bc6qz6pbh9tqcfbcorjk4...@mail.gmail.com%3e]
> these classes currently pass null values along to Deserializers, so those
> Deserializers need to handle null inputs and pass them through without
> throwing. It would be better for these classes to simply not call the
> Deserializers in this case; this would reduce the burden of implementers of
> {{Deserializer}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
