Thanks Grant. A few comments inline. On Mon, Jun 20, 2016 at 9:09 PM, Grant Henke <ghe...@cloudera.com> wrote:
> > 2. If there are multiple instructions for the same topic in one > > request the extra request will be ignored > > - This is because the list of topics is modeled server side as a > set > > - Multiple deletes results in the same end goal, so handling this > > error for the user should be okay > One potential issue is that the number of topics in the response won't match the number of topics in the request. Worth checking what others think of this one. 4. When requesting to delete a topic that is already marked for > > deletion, the request will wait for the wait for the timeout and > return as > > usual Do you mean that it will wait up to the timeout until the delete is "complete" as per the definition in `6`? Or will it wait unconditionally until the timeout expires? It would be good to make that clear. > > 5. The principal must be authorized to the "Delete" Operation on the > > "Topic" resource to delete the topic. > > - Unauthorized requests will receive a TopicAuthorizationException > This could leak topic name information (as per KAFKA-3396, which was filed by you). We would probably want to return `InvalidTopic` for the case where the user doesn't have a valid `DESCRIBE TOPIC` ACL, right? > > - Why have a timeout at all? Deletes could take a while? > I was wondering (and this applies to the create topic as well), is there any value in a flag that says whether the timeout expired or not? Thanks, Ismael
