[ https://issues.apache.org/jira/browse/KAFKA-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322678#comment-15322678 ]
ASF GitHub Bot commented on KAFKA-3753: --------------------------------------- GitHub user jklukas opened a pull request: https://github.com/apache/kafka/pull/1486 KAFKA-3753: Add size() method to KeyValueStore interface See https://issues.apache.org/jira/browse/KAFKA-3753 This contribution is my original work and I license the work to the project under the project's open source license. cc @guozhangwang @kichristensen @ijuma You can merge this pull request into a Git repository by running: $ git pull https://github.com/jklukas/kafka kvstore-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1486 ---- commit c4ea7cd0ed4d822e65cee3fd283f81c29ce11d57 Author: Jeff Klukas <j...@klukas.net> Date: 2016-06-09T15:08:33Z Add size() method to KeyValueStore interface ---- > Metrics for StateStores > ----------------------- > > Key: KAFKA-3753 > URL: https://issues.apache.org/jira/browse/KAFKA-3753 > Project: Kafka > Issue Type: Improvement > Components: streams > Reporter: Jeff Klukas > Assignee: Guozhang Wang > Priority: Minor > Labels: api > Fix For: 0.10.1.0 > > > As a developer building a Kafka Streams application, I'd like to have > visibility into what's happening with my state stores. How can I know if a > particular store is growing large? How can I know if a particular store is > frequently needing to hit disk? > I'm interested to know if there are existing mechanisms for extracting this > information or if other people have thoughts on how we might approach this. > I can't think of a way to provide metrics generically, so each state store > implementation would likely need to handle this separately. Given that the > default RocksDBStore will likely be the most-used, it would be a first target > for adding metrics. > I'd be interested in knowing the total number of entries in the store, the > total size on disk and in memory, rates of gets and puts, and hit/miss ratio > for the MemoryLRUCache. Some of these numbers are likely calculable through > the RocksDB API, others may simply not be accessible. > Would there be value to the wider community in having state stores register > metrics? -- This message was sent by Atlassian JIRA (v6.3.4#6332)