[ 
https://issues.apache.org/jira/browse/KAFKA-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319529#comment-15319529
 ] 

Randall Hauch commented on KAFKA-3803:
--------------------------------------

BTW, I had no idea until I started looking into this and saw the {{StructTest}} 
code that {{ByteBuffer}} is preferred over {{byte[]}} for field values in 
Struct objects. Not sure where that should be documented, but it needs to be 
better documented somewhere -- perhaps Struct?

> JsonConverter deserialized Struct containing bytes field does not return true 
> for equals()
> ------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-3803
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3803
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.10.0.0
>            Reporter: Ewen Cheslack-Postava
>
> The problem is that byte[] comparisons will return false for equality, so 
> even if the two are effectively equal, Struct.equals will not return true.
> It's unclear if this should be fixed or not. Equality wouldn't work for map 
> or array types containing bytes either. However, on possibility is making 
> ByteBuffer the default instead to alleviate this, although then we may end up 
> with asymmetry in equality.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to