[
https://issues.apache.org/jira/browse/KAFKA-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318756#comment-15318756
]
ASF GitHub Bot commented on KAFKA-3711:
---------------------------------------
GitHub user jklukas opened a pull request:
https://github.com/apache/kafka/pull/1479
KAFKA-3711: Ensure a RecordingMap is passed to configured instances
See https://issues.apache.org/jira/browse/KAFKA-3711
I've tested locally that this change does indeed resolve the warning I
mention in the ticket:
```
org.apache.kafka.clients.consumer.ConsumerConfig: The configuration
metric.dropwizard.registry = kafka-metrics was supplied but isn't a known
config.
```
where `metric.dropwizard.registry` is a configuration value defined in a
custom `MetricReporter`
(https://github.com/SimpleFinance/kafka-dropwizard-reporter).
With this change, the above warning no longer appears, as @ewencp predicted.
This contribution is my original work and I license the work to the project
under the project's open source license.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jklukas/kafka abstractconfig-originals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1479
----
commit 5c7a41b3116bb65db3cc0ca5cb90521766d41fcb
Author: Jeff Klukas <j...@klukas.net>
Date: 2016-06-07T14:33:32Z
Ensure a RecordingMap is passed to configured instances
----
> Allow configuration of MetricsReporter subclasses
> -------------------------------------------------
>
> Key: KAFKA-3711
> URL: https://issues.apache.org/jira/browse/KAFKA-3711
> Project: Kafka
> Issue Type: Improvement
> Components: clients, streams
> Reporter: Jeff Klukas
> Assignee: Guozhang Wang
> Priority: Minor
> Fix For: 0.10.1.0
>
>
> The current interface for attaching metrics reporters to clients allows only
> defining a list of class names, but provides no means for configuring those
> reporters.
> There is at least one existing project
> (https://github.com/apakulov/kafka-graphite) that solves this problem by
> passing additional properties into the client, which then get passed on to
> the reporter. This seems to work quite well, but it generates warnings like
> {{The configuration kafka.graphite.metrics.prefix = foo was supplied but
> isn't a known config.}}
> Should passing arbitrary additional parameters like this be officially
> supported as the way to configure metrics reporters? Should these warnings
> about unrecognized parameters be removed?
> Perhaps there should be some mechanism for registering additional
> configuration parameters for clients to expect?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
