+1 (non-binding) on the proposal. Just a minor suggestion. I am wondering should we change the config name to " log.cleaner.compaction.delay.ms"? The first glance at the configuration name is a little confusing. I was thinking do we have a "max" lag? And is this "lag" a bad thing?
Thanks, Jiangjie (Becket) Qin On Tue, May 24, 2016 at 4:21 PM, Gwen Shapira <g...@confluent.io> wrote: > +1 (binding) > > Thanks for responding to all my original concerns in the discussion thread. > > On Tue, May 24, 2016 at 1:37 PM, Eric Wasserman <eric.wasser...@gmail.com> > wrote: > > > Hi, > > > > I would like to begin voting on KIP-58 - Make Log Compaction Point > > Configurable > > > > KIP-58 is here: < > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-58+-+Make+Log+Compaction+Point+Configurable > > > > > > > The Jira ticket KAFKA-1981 Make log compaction point configurable > > is here: <https://issues.apache.org/jira/browse/KAFKA-1981> > > > > The original pull request is here: < > > https://github.com/apache/kafka/pull/1168> > > (this includes configurations for size and message count lags that will > be > > removed per discussion of KIP-58). > > > > The vote will run for 72 hours. > > >
