[
https://issues.apache.org/jira/browse/KAFKA-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290233#comment-15290233
]
ASF GitHub Bot commented on KAFKA-3722:
---------------------------------------
GitHub user MayureshGharat opened a pull request:
https://github.com/apache/kafka/pull/1403
KAFKA-3722 : The PlaintextChannelBuilder should always use the
DefaultPrincipalBuilder
Consider this scenario :
1) We have a Kafka Broker running on PlainText and SSL port simultaneously.
2) We try to plugin a custom principal builder using the config
"principal.builder.class" for the request coming over the SSL port.
3) The ChannelBuilders.createPrincipalBuilder(configs) first checks if a
config "principal.builder.class" is specified in the passed in configs and
tries to use that even when it is building the instance of PrincipalBuilder for
the PlainText port, when that custom principal class is only menat for SSL port.
IMO, having a DefaultPrincipalBuilder for PlainText port should be fine.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MayureshGharat/kafka KAFKA-3722
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1403.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1403
----
commit e5227268140b2dbd8d0828449ee398a75549c8be
Author: MayureshGharat <gharatmayures...@gmail.com>
Date: 2016-05-19T01:19:37Z
The PlaintextChannelBuilder should always use the DefaultPrincipalBuilder
----
> PlaintextChannelBuilder should not use
> ChannelBuilders.createPrincipalBuilder(configs) for creating instance of
> PrincipalBuilder
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-3722
> URL: https://issues.apache.org/jira/browse/KAFKA-3722
> Project: Kafka
> Issue Type: Bug
> Reporter: Mayuresh Gharat
> Assignee: Mayuresh Gharat
>
> Consider this scenario :
> 1) We have a Kafka Broker running on PlainText and SSL port simultaneously.
> 2) We try to plugin a custom principal builder using the config
> "principal.builder.class" for the request coming over the SSL port.
> 3) The ChannelBuilders.createPrincipalBuilder(configs) first checks if a
> config "principal.builder.class" is specified in the passed in configs and
> tries to use that even when it is building the instance of PrincipalBuilder
> for the PlainText port, when that custom principal class is only menat for
> SSL port.
> IMO, having a DefaultPrincipalBuilder for PalinText port should be fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
