[
https://issues.apache.org/jira/browse/KAFKA-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290181#comment-15290181
]
ASF GitHub Bot commented on KAFKA-3664:
---------------------------------------
GitHub user vahidhashemian reopened a pull request:
https://github.com/apache/kafka/pull/1363
KAFKA-3664 (WIP): Commit offset of unsubscribed partitions of the new
consumer on a subscription change
When users are using group management, if they call consumer.subscribe() to
change the subscription, the removed subscriptions will be immediately removed
and their offset will not be committed.
Also the revoked partitions passed to the
ConsumerRebalanceListener.onPartitionsRevoked() will not include those
partitions.
This pull request fixes this issue by following the design suggested by
@becketqin
[here](https://issues.apache.org/jira/browse/KAFKA-3664?focusedCommentId=15274470&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15274470).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka KAFKA-3664
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1363
----
commit 68e6b5507e6c587b035655c5c010bef5c282c7f7
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date: 2016-05-13T00:23:27Z
KAFKA-3664: Commit offset of unsubscribed partitions of the new consumer on
a subscription change
When users are using group management, if they call consumer.subscribe() to
change the subscription, the removed subscriptions are immediately removed and
their offset are not committed.
This pull request fixes this issue.
----
> When subscription set changes on new consumer, the partitions may be removed
> without offset being committed.
> ------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-3664
> URL: https://issues.apache.org/jira/browse/KAFKA-3664
> Project: Kafka
> Issue Type: Bug
> Reporter: Jiangjie Qin
> Assignee: Vahid Hashemian
>
> When users are using group management, if they call consumer.subscribe() to
> change the subscription, the removed subscriptions will be immediately
> removed and their offset will not be commit. Also the revoked partitions
> passed to the ConsumerRebalanceListener.onPartitionsRevoked() will not
> include those partitions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
