[ 
https://issues.apache.org/jira/browse/KAFKA-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274552#comment-15274552
 ] 

ASF GitHub Bot commented on KAFKA-3669:
---------------------------------------

GitHub user markgrover opened a pull request:

    https://github.com/apache/kafka/pull/1334

    KAFKA-3669: Add secondary constructor for KafkaConfig with a default …

    …value for doLog

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markgrover/kafka kafka-3669-trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1334
    
----
commit 74a1e1e53aa5936791b7d61d595d4d7a769ca9a3
Author: Mark Grover <m...@apache.org>
Date:   2016-05-06T18:45:24Z

    KAFKA-3669: Add secondary constructor for KafkaConfig with a default value 
for doLog

----


> Add secondary constructor for KafkaConfig with a default value for doLog
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-3669
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3669
>             Project: Kafka
>          Issue Type: Bug
>          Components: config
>    Affects Versions: 0.10.0.0, 0.11.0.0
>            Reporter: Mark Grover
>            Priority: Critical
>
> KAFKA-3052 changed the public signature of the KafkaConfig class. I was 
> testing Kafka 0.10.0 RC2 and found that [this 
> change|https://github.com/apache/kafka/commit/5b5f002fceee7c1b16298b0eaf176ca49d98c025]
>  that added a secondary constructor to KafkaConfig to keep things API 
> compatible, was only added to 0.9.0, and is missing from both 0.10.0 and 
> trunk branches.
> Can we please port this change there too?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to