[ https://issues.apache.org/jira/browse/KAFKA-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242942#comment-15242942 ]
ASF GitHub Bot commented on KAFKA-3558: --------------------------------------- GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/1225 KAFKA-3558; Add compression_type parameter to benchmarks in benchmark_test.py * Use a fixed `Random` seed in `EndToEndLatency.scala` for determinism * Add `compression_type` to and remove `consumer_fetch_max_wait` from `end_to_end_latency.py`. The latter was never used. * Tweak logging of `end_to_end_latency.py` to be similar to `consumer_performance.py`. * Add `compression_type` to `benchmark_test.py` methods and add `snappy` to `matrix` annotation * Use randomly generated bytes from a restricted range for `ProducerPerformance` payload. This is a simple fix for now. It can be improved in the PR for KAFKA-3554. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-3558-add-compression_type-benchmark_test.py Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1225.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1225 ---- commit 861208470c511881063876e7834f9526795cafb2 Author: Ismael Juma <ism...@juma.me.uk> Date: 2016-04-14T12:52:33Z Minor clean-ups in `ConsumerPerformance` commit da504f09d141adc9e0330e682d5d7a67f4992522 Author: Ismael Juma <ism...@juma.me.uk> Date: 2016-04-14T12:53:49Z Use a fixed `Random` seed in `EndToEndLatency.scala` and minor clean-up commit 629cd7400e3b31b87119704052e685fead153eab Author: Ismael Juma <ism...@juma.me.uk> Date: 2016-04-14T13:06:48Z Add `compression_type` to and remove `consumer_fetch_max_wait` from `end_to_end_latency.py` Also tweak logging in `end_to_end_latency.py` to match what we do in `consumer_performance.py` commit b3de8b0083ee5b81c9c50fcd326374500558f710 Author: Ismael Juma <ism...@juma.me.uk> Date: 2016-04-14T13:08:51Z Add `compression_type` to `benchmark_test.py` commit 06d58913e54025a1cb2ca97dc6fe2b3ca91ea281 Author: Ismael Juma <ism...@juma.me.uk> Date: 2016-04-14T13:31:52Z Use randomly generated bytes from a restricted range for `ProducerPerformance` payload Used the same range as `EndToEndLatency` ---- > Add compression_type parameter to benchmarks in benchmark_test.py > ----------------------------------------------------------------- > > Key: KAFKA-3558 > URL: https://issues.apache.org/jira/browse/KAFKA-3558 > Project: Kafka > Issue Type: Improvement > Components: system tests > Reporter: Ismael Juma > Assignee: Ismael Juma > > Our nightly performance tests should include scenarios involving compression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)