[
https://issues.apache.org/jira/browse/KAFKA-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196842#comment-15196842
]
ASF GitHub Bot commented on KAFKA-3260:
---------------------------------------
GitHub user ewencp opened a pull request:
https://github.com/apache/kafka/pull/1080
MINOR: KAFKA-3260 follow up, fix commitRecord calls in tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ewencp/kafka minor-kafka-3260-followup-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1080
----
commit 8b3bfbf78a9afddb4aaff9ac672c9b61547d5ac4
Author: Ewen Cheslack-Postava <m...@ewencp.org>
Date: 2016-03-16T06:18:29Z
MINOR: KAFKA-3260 follow up, fix commitRecord calls in tests
----
> Increase the granularity of commit for SourceTask
> -------------------------------------------------
>
> Key: KAFKA-3260
> URL: https://issues.apache.org/jira/browse/KAFKA-3260
> Project: Kafka
> Issue Type: Improvement
> Components: copycat
> Affects Versions: 0.9.0.1
> Reporter: Jeremy Custenborder
> Assignee: Ewen Cheslack-Postava
> Fix For: 0.10.0.0
>
>
> As of right now when commit is called the developer does not know which
> messages have been accepted since the last poll. I'm proposing that we extend
> the SourceTask class to allow records to be committed individually.
> {code}
> public void commitRecord(SourceRecord record) throws InterruptedException
> {
> // This space intentionally left blank.
> }
> {code}
> This method could be overridden to receive a SourceRecord during the callback
> of producer.send. This will give us messages that have been successfully
> written to Kafka. The developer then has the capability to commit messages to
> the source individually or in batch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
