[
https://issues.apache.org/jira/browse/KAFKA-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192579#comment-15192579
]
ASF GitHub Bot commented on KAFKA-3388:
---------------------------------------
GitHub user becketqin opened a pull request:
https://github.com/apache/kafka/pull/1056
KAFKA-3388: Fix expiration of batches sitting in the accumulator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becketqin/kafka KAFKA-3388
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1056.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1056
----
commit 7561b81254d4361122c3467b741f98f37a769b29
Author: Jiangjie Qin <becket....@gmail.com>
Date: 2016-03-13T23:57:52Z
KAFKA-3388: Fix expiration of batches sitting in the accumulator
----
> Producer should only timeout a batch in the accumulator when metadata is
> missing.
> ---------------------------------------------------------------------------------
>
> Key: KAFKA-3388
> URL: https://issues.apache.org/jira/browse/KAFKA-3388
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.9.0.1
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
> Priority: Blocker
> Fix For: 0.10.0.0
>
>
> In KIP-19 we are reusing the request.timeout.ms to timeout the batches in the
> accumulator. We were intended to avoid the case that the batches sitting in
> the accumulator forever when topic metadata is missing.
> Currently we are not checking if metadata is available or not when we timeout
> the batches in the accumulator (although the comments says we will check the
> metadata). This causes problem that once the previous batch hit a request
> timeout and got retried, all the subsequent batches will fail with timeout
> exception. We should only timeout the batches in the accumulator when the
> metadata of the partition is missing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
