[
https://issues.apache.org/jira/browse/KAFKA-3312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185731#comment-15185731
]
ASF GitHub Bot commented on KAFKA-3312:
---------------------------------------
GitHub user vahidhashemian reopened a pull request:
https://github.com/apache/kafka/pull/1025
KAFKA-3312: Add utility offset methods to ZkUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka KAFKA-3312
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1025.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1025
----
commit 8ee7711d11c6eb32f160c66202c54af2e17c3ed6
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date: 2016-03-05T00:47:05Z
KAFKA-3312: Add utility offset methods to ZkUtils
----
> Add a offsets methods to ZkUtils and replace relevant usages
> ------------------------------------------------------------
>
> Key: KAFKA-3312
> URL: https://issues.apache.org/jira/browse/KAFKA-3312
> Project: Kafka
> Issue Type: Improvement
> Reporter: Grant Henke
> Assignee: Vahid Hashemian
>
> There are many places in the code that manually build a zookeeper path and
> get or update offsets. Moving this logic to a common location in ZkUtils
> would be nice.
> Ex:
> {code}
> zkUtils.readDataMaybeNull(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}")._1
> {code}
> {code}
> zkUtils.readData(topicDirs.consumerOffsetDir + "/" +
> topicAndPartition.partition)._1.toLong
> {code}
> {code}
> zkUtils.updatePersistentPath(s"${topicDirs.consumerOffsetDir}/${topicPartition.partition}",
> partitionData.offset.toString)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
