[ 
https://issues.apache.org/jira/browse/KAFKA-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157821#comment-15157821
 ] 

Ismael Juma commented on KAFKA-2970:
------------------------------------

>From a protocol perspective, it's probably OK to go that way.

One concern I have is about API compatibility guarantees. Maybe these classes 
should live under an internal package so that we can actually change them if we 
have to? `o.a.k.common` classes are public API.

> Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint 
> class
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-2970
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2970
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 0.9.0.0
>            Reporter: Grant Henke
>            Assignee: chen zhu
>
> Both UpdateMetadataRequest.java and LeaderAndIsrRequest.java have an Endpoint 
> class which contain the same information. These should be consolidated for 
> simplicity and inter-opt. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to