[
https://issues.apache.org/jira/browse/KAFKA-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156659#comment-15156659
]
ASF GitHub Bot commented on KAFKA-3259:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/943
KAFKA-3259 KAFKA-3253; KIP-31/KIP-32 Follow-up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka kafka-3259-kip-31-32-clean-ups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/943.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #943
----
commit cb6dda92656e26b69b8134ef76b7ceee4a26ee27
Author: Ismael Juma <[email protected]>
Date: 2016-02-18T09:59:44Z
Replace multiple catch blocks by a single one with multiple clauses
commit dd8382b38bfda6acb3b97d3cc5bb1f2e093fbc8b
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T07:18:56Z
Several code style and documentation wording improvements
commit 7902940adabb07192d09e171e1709f72eb16adf3
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T07:25:43Z
Use `Ordered` methods for `ApiVersion` comparison instead of `onOrAfter`
Also improve error-handling in `apply`
commit b1e95ab66e1e3c4e34bc7b9e03aab8757b66f5fa
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T07:26:17Z
Move `MorrorMakerMessageHandler` node to correct section in upgrade notes
commit a2d6fa4b53a5299f8a1661fa553f33654d0775c8
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T07:31:31Z
Eliminate redundant collection traversals in `LogCleaner`
commit c0a927e83e6dfdf0cc7c52bec279d186c42d2ff7
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T07:43:34Z
Don't mutate passed in `topicConfig` in `TopicConfigHandler`
commit 7846aef0b012f3f2f197a65679cb2f527b90cd0c
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T07:57:31Z
Also test `UncleanLeaderElectionEnableProp` in `testFromPropsInvalid`
commit 45b0e1eb01fbd39549b635c0416e377481879e34
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T08:05:45Z
Use `convertedPartitionData` when throttling clients
commit cd726334e88d4ff255c1432eb5c9d782f8090242
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T08:36:33Z
KAFKA-3253: Skip duplicate message size check if there is no re-compression
during log appending
commit c2ec781f689177f85b6517d971467afea7547318
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T08:51:15Z
A few clean-ups in `ByteBufferMessageSet`
The most notable one is using `LongRef` instead of
`AtomicLong`, which meant that many other classes
also had to be updated.
commit 4955f953336e8218be861e86550e96440a4d10e7
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T08:52:04Z
Use `TimestampType` and `ApiVersion` in `KafkaConfig` instead of `String`
commit 635178ad4cb647439d1133b0030394ec43e1658f
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T08:53:29Z
Add `is` prefix to `magicValueInAllWrapperMessages` method
This makes it clear that it returns a `boolean`
commit 6f68a3b68d7e5c275f1606ac0424a9ca8ec300d3
Author: Ismael Juma <[email protected]>
Date: 2016-02-22T09:02:29Z
Improve `TimestampType` naming and switch static to instance method
----
> KIP-31/KIP-32 clean-ups
> -----------------------
>
> Key: KAFKA-3259
> URL: https://issues.apache.org/jira/browse/KAFKA-3259
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 0.9.1.0
>
>
> During review, I found a few things that could potentially be improved but
> were not important enough to block the PR from being merged.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
