[
https://issues.apache.org/jira/browse/KAFKA-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149556#comment-15149556
]
ASF GitHub Bot commented on KAFKA-3242:
---------------------------------------
GitHub user benstopford opened a pull request:
https://github.com/apache/kafka/pull/924
KAFKA-3242: minor rename / logging change to Controller
KAFKA-3242: minor rename / logging change to references to 'adding
partitions' to indicate 'modifying partitions'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benstopford/kafka small_changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/924.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #924
----
commit e2dfcf98b70dfd3a97b30cad25b6b74abbd191b1
Author: Ben Stopford <benstopf...@gmail.com>
Date: 2016-02-16T22:30:49Z
KAFKA-3242: minor rename / logging change to refererences to 'adding
partitions' to indicate 'modifying partitions'
----
> "Add Partition" log message doesn't actually indicate adding a partition
> ------------------------------------------------------------------------
>
> Key: KAFKA-3242
> URL: https://issues.apache.org/jira/browse/KAFKA-3242
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
>
> We log:
> "Add Partition triggered " ... " for path "...
> on every trigger of addPartitionListener
> The listener is triggered not just when partition is added but on any
> modification of the partition assignment in ZK. So this is a bit misleading.
> Calling the listener updatePartitionListener and logging something more
> meaningful will be nice.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
