[
https://issues.apache.org/jira/browse/KAFKA-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121798#comment-15121798
]
ASF GitHub Bot commented on KAFKA-3161:
---------------------------------------
GitHub user crhyne opened a pull request:
https://github.com/apache/kafka/pull/824
KAFKA-3161: Fixed ProducerConfig/ConsumerConfig so that defaults are used
in java.util.Properties
This impacts the ProducerConfig and ConsumerConfig. I added a unit test to
reflect the new case. While running unit tests I found that the order for
assertEquals(<expected>, <actual>) were backwards - I fixed this.
This is my original work to be licensed to the kafka product (Instructions
5d).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/crhyne/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #824
----
commit 5c46a2711b5927b91d3076cd35675c1dd5eb6ca3
Author: Cliff Rhyne <crh...@signal.co>
Date: 2016-01-28T16:02:08Z
cleaned up use of java.util.Properties so that defaults are used
https://issues.apache.org/jira/browse/KAFKA-3161
----
> Refactor Java client's use of the Properties class
> --------------------------------------------------
>
> Key: KAFKA-3161
> URL: https://issues.apache.org/jira/browse/KAFKA-3161
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 0.9.0.0
> Reporter: Cliff Rhyne
>
> The KafkaConsumer takes a Properties class for the config, but then instead
> of using it's getProperty() function the class gets copied (which breaks the
> use of defaults).
> One example is this from ConsumerConfig:
> Properties newProperties = new Properties();
> newProperties.putAll(properties);
> Which could be re-written as:
> Properties newProperties = new Properties(properties);
> This is important because applications using the client library expect to be
> able to specify the default properties above.
> (I'm not sure how to go about this, but I'm working on the change locally
> right now. I'd like to assign it to myself but I guess I can't because i'm
> not on the contributor list).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
