[ https://issues.apache.org/jira/browse/KAFKA-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116669#comment-15116669 ]
ASF GitHub Bot commented on KAFKA-3054: --------------------------------------- GitHub user ZoneMayor reopened a pull request: https://github.com/apache/kafka/pull/782 KAFKA-3054: Connect Herder fail if sent a wrong connector config or task config, catch exceptions to guard The exceptions may propagate to DistributedHerder when start or stop connectors or tasks; The best solution is to track the track the status of connectors and tasks; This patch catch exceptions to guard the DistributedHerder; this a short-term solution; You can merge this pull request into a Git repository by running: $ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-3054 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/782.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #782 ---- commit 34240b52e1b70aa172b65155f6042243d838b420 Author: ZoneMayor <jinxing6...@126.com> Date: 2015-12-18T07:22:20Z Merge pull request #12 from apache/trunk 2015-12-18 commit 52d02f333e86d06cfa8fff5facd18999b3db6d83 Author: ZoneMayor <jinxing6...@126.com> Date: 2015-12-30T03:08:08Z Merge pull request #13 from apache/trunk 2015-12-30 commit d56be0b9e0849660c07d656c6019f9cc2f17ae55 Author: ZoneMayor <jinxing6...@126.com> Date: 2016-01-10T09:24:06Z Merge pull request #14 from apache/trunk 2016-1-10 commit e75c8bbb3329868f92becc86645d31fa21c6c7f4 Author: jinxing <jinx...@fenbi.com> Date: 2016-01-17T03:11:45Z KAFKA-3054: Connect Herder fail if sent a wrong connector config or task config, catch exceptions to guard commit efd6023821df014b06e509c1a13fd4e9d08113cb Author: jinxing <jinx...@fenbi.com> Date: 2016-01-25T13:20:36Z catch the exception thrown during stopping connector or task and try to restart commit d05af92d44ed26001f0ec96f5376790d2009249e Author: jinxing <jinx...@fenbi.com> Date: 2016-01-25T13:22:45Z small fix commit b6521f7d90b8fabfe3bfd086c188977d444660b5 Author: jinxing <jinx...@fenbi.com> Date: 2016-01-25T13:23:12Z small fix ---- > Connect Herder fail forever if sent a wrong connector config or task config > --------------------------------------------------------------------------- > > Key: KAFKA-3054 > URL: https://issues.apache.org/jira/browse/KAFKA-3054 > Project: Kafka > Issue Type: Bug > Components: copycat > Affects Versions: 0.9.0.0 > Reporter: jin xing > Assignee: jin xing > > Connector Herder throws ConnectException and shutdown if sent a wrong config, > restarting herder will keep failing with the wrong config; It make sense that > herder should stay available when start connector or task failed; After > receiving a delete connector request, the herder can delete the wrong config > from "config storage" -- This message was sent by Atlassian JIRA (v6.3.4#6332)