[
https://issues.apache.org/jira/browse/KAFKA-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097844#comment-15097844
]
ASF GitHub Bot commented on KAFKA-3087:
---------------------------------------
GitHub user rajubairishetti opened a pull request:
https://github.com/apache/kafka/pull/772
KAFKA-3087: Fix retention.ms property documentation in config docs
Log retention settings can be set it in broker and some properties can be
overriden at topic level.
|Property |Default|Server Default property| Description|
|retention.ms|7 days|log.retention.minutes|This configuration controls the
maximum time we will retain a log before we will discard old log segments to
free up space if we are using the "delete" retention policy. This represents an
SLA on how soon consumers must read their data.|
But retention.ms is in milli seconds not in minutes. So corresponding
*Server Default property* should be *log.retention.ms* instead of
*log.retention.minutes*.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajubairishetti/kafka KAFKA-3087
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #772
----
commit 7ea672013f5d028986f869fc6bf6a5c409655ef7
Author: raju <r...@apache.org>
Date: 2016-01-14T08:53:04Z
KAFKA-3087: Fix retention.ms property documentation in config docs
----
> Fix documentation for retention.ms property and update documentation for
> LogConfig.scala class
> ----------------------------------------------------------------------------------------------
>
> Key: KAFKA-3087
> URL: https://issues.apache.org/jira/browse/KAFKA-3087
> Project: Kafka
> Issue Type: Bug
> Components: log
> Reporter: Raju Bairishetti
> Assignee: Jay Kreps
> Priority: Critical
> Labels: documentation
>
> Log retention settings can be set it in broker and some properties can be
> overriden at topic level.
> |Property |Default|Server Default property| Description|
> |retention.ms|7 days|log.retention.minutes|This configuration controls the
> maximum time we will retain a log before we will discard old log segments to
> free up space if we are using the "delete" retention policy. This represents
> an SLA on how soon consumers must read their data.|
> But retention.ms is in milli seconds not in minutes. So corresponding *Server
> Default property* should be *log.retention.ms* instead of
> *log.retention.minutes*.
> It would be better if we mention the if the time age is in
> millis/minutes/hours in the documentation page and documenting in code as
> well (Right now, it is saying *age in the code*. We should specify the *age
> in time granularity).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
