[
https://issues.apache.org/jira/browse/KAFKA-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093411#comment-15093411
]
ASF GitHub Bot commented on KAFKA-3085:
---------------------------------------
GitHub user dajac opened a pull request:
https://github.com/apache/kafka/pull/756
KAFKA-3085: BrokerChangeListener computes inconsistent live/dead broker
list.
Follow up PR as per comments in the ticket.
@junrao It should be correct now as `curBrokers` included only live brokers
and live/dead brokers are computed based on it. Could you take a look when you
have time?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dajac/kafka KAFKA-3085
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/756.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #756
----
commit 94edafcf9d77a25ef5506cff9a3e9a1e76ff14ca
Author: David Jacot <david.ja...@gmail.com>
Date: 2016-01-12T06:42:40Z
BrokerChangeListener computes inconsistent live/dead broker list.
----
> BrokerChangeListener computes inconsistent live/dead broker list
> ----------------------------------------------------------------
>
> Key: KAFKA-3085
> URL: https://issues.apache.org/jira/browse/KAFKA-3085
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.9.0.0
> Reporter: Jun Rao
> Assignee: David Jacot
>
> On a broker change ZK event, BrokerChangeListener gets the current broker
> list from ZK. It then computes a new broker list, a dead broker list, and a
> live broker list with more detailed broker info. The new and live broker list
> are computed by reading the value associated with each of the current broker
> twice. If a broker is de-registered in between, these two list will not be
> consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
