GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/652
MINOR: Use equals instead of == A few issues found via static analysis. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka use-equals-instead-of-== Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/652.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #652 ---- commit 0175171caf8e974d49a262b6de510b467655889d Author: Edward Ribeiro <edward.ribe...@gmail.com> Date: 2015-09-01T03:24:04Z MockClient's disconnect() method has two bugs * First, it compares Strings using `==` instead of `equals()`. * Second, it tries to remove a String from a Set<Integer>. commit 202093842348fc88fd4e13e6c2867c60b732c453 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-12-09T16:41:05Z Use `equals` instead of `==` ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---