[jira] [Commented] (KAFKA-2965) Two variables should be exchanged.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047898#comment-15047898
 ] 

ASF GitHub Bot commented on KAFKA-2965:
---------------------------------------

GitHub user boweite opened a pull request:

    https://github.com/apache/kafka/pull/646

    [KAFKA-2965]Two variables should be exchanged.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/boweite/kafka kafka-2965

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/646.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #646
    
----
commit ad71fb59dc5e9db1a9ceea20a9b320e0885ba146
Author: unknown <w00312...@szxbz258.huaweiobz.com>
Date:   2015-12-09T02:28:50Z

    change variables

----


> Two variables should be exchanged.
> ----------------------------------
>
>                 Key: KAFKA-2965
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2965
>             Project: Kafka
>          Issue Type: Bug
>          Components: controller
>    Affects Versions: 0.9.0.0
>         Environment: NA
>            Reporter: Bo Wang
>            Priority: Minor
>              Labels: bug
>         Attachments: Kafka-2965.patch
>
>
> Two variables should be exchanged in KafkaController.scala as follows：
> val topicsForWhichPartitionReassignmentIsInProgress = 
> controllerContext.partitionsUndergoingPreferredReplicaElection.map(_.topic)
> val topicsForWhichPreferredReplicaElectionIsInProgress = 
> controllerContext.partitionsBeingReassigned.keySet.map(_.topic)
> val topicsIneligibleForDeletion = topicsWithReplicasOnDeadBrokers | 
> topicsForWhichPartitionReassignmentIsInProgress |
>                                   
> topicsForWhichPreferredReplicaElectionIsInProgress
> Should change to:
> val topicsForWhichPreferredReplicaElectionIsInProgress = 
> controllerContext.partitionsUndergoingPreferredReplicaElection.map(_.topic)
> val topicsForWhichPartitionReassignmentIsInProgress = 
> controllerContext.partitionsBeingReassigned.keySet.map(_.topic)
>     val topicsIneligibleForDeletion = topicsWithReplicasOnDeadBrokers | 
> topicsForWhichPartitionReassignmentIsInProgress |
>                                   
> topicsForWhichPreferredReplicaElectionIsInProgress



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)