[
https://issues.apache.org/jira/browse/KAFKA-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008607#comment-15008607
]
ASF GitHub Bot commented on KAFKA-2847:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/542
KAFKA-2847; Remove principal builder class from client configs
Also mark `PrincipalBuilder` as `Unstable` and tweak docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-2847-remove-principal-builder-class-from-client-configs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit 88ccdfb961ec4adc82121b1ed44a198a4dbe4f89
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2015-11-17T12:48:25Z
Remove principal.builder.class from client configs
commit ce2c307bae8da40bed4eb53cc209c65973b72331
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2015-11-17T12:52:35Z
Mark the `PrincipalBuilder` interface as `Unstable`
I think it would be good to use it for SASL too and that may
require the interface to be changed.
commit 70249b1502e32c0ea484e398b318545a500ecb12
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2015-11-17T12:53:44Z
Mention in docs for `PRINCIPAL_BUILDER_CLASS_DOC` that it's only used for
`SecurityProtocol.SSL`
----
> remove principal.builder.class from client configs
> --------------------------------------------------
>
> Key: KAFKA-2847
> URL: https://issues.apache.org/jira/browse/KAFKA-2847
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Affects Versions: 0.9.0.0
> Reporter: Jun Rao
> Assignee: Ismael Juma
>
> Since only the broker needs to know the principal name, we can remove
> principal.builder.class from both the producer and the consumer client config.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
