Geoff Anderson created KAFKA-2789: ------------------------------------- Summary: Update upgrade system test to catch issue reported in KAFKA-2756 Key: KAFKA-2789 URL: https://issues.apache.org/jira/browse/KAFKA-2789 Project: Kafka Issue Type: Bug Reporter: Geoff Anderson Assignee: Geoff Anderson Fix For: 0.9.0.0
It's not good that the upgrade system test didn't catch KAFKA-2756 Hypothesis: We think KAFKA-2756 would manifest as failed fetch requests, and replicas falling out of ISR set. However, the test only validates that acked messages are available for consumption. It may be that some messages simply were not acked, but this is not currently a failure condition for the test Proposed update: - Since every shutdown is a clean shutdown, and `min.insync.isr = 2`, we expect that every message should be acked in this test. Update validation to confirm this. - Depending on how the leader moves during the rolling bounces, it might be still be possible for every message to be acked even if replicas fall out of isr. So we should also verify after each bounce that the size of the isr set goes back to 3 in a short period of time. When making this test update, we should check that the test fails if we remove the fix to KAFKA-2756 -- This message was sent by Atlassian JIRA (v6.3.4#6332)