[
https://issues.apache.org/jira/browse/KAFKA-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974166#comment-14974166
]
ASF GitHub Bot commented on KAFKA-2688:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/359
KAFKA-2688; Avoid forcing reload of `Configuration`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
kafka-2688-avoid-forcing-reload-of-configuration
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/359.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #359
----
commit ab829485798b818840c4f37eb888a22c4eed59e9
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2015-10-26T12:59:38Z
Remove forced reload of `Configuration` from `Login` and set JAAS property
before starting `MiniKdc`
----
> Avoid forcing reload of `Configuration`
> ---------------------------------------
>
> Key: KAFKA-2688
> URL: https://issues.apache.org/jira/browse/KAFKA-2688
> Project: Kafka
> Issue Type: Bug
> Components: security
> Reporter: Ismael Juma
> Priority: Critical
> Fix For: 0.9.0.0
>
>
> We currently call `Configuration.setConfiguration(null)` from a couple of
> places in our codebase (`Login` and `JaasUtils`) to force `Configuration` to
> be reloaded. If this code is removed, some tests can fail depending on the
> test execution order.
> Ideally we would not need to call `setConfiguration(null)` outside of tests.
> Investigate if this is possible. If not, we should at least ensure that
> reloads are done in a safe way within our codebase (perhaps using a lock).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
