[ 
https://issues.apache.org/jira/browse/KAFKA-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismael Juma updated KAFKA-2460:
-------------------------------
    Reviewer: Jun Rao
      Status: Patch Available  (was: Open)

Harsha, I hope you don't mind; I submitted a PR for this:

https://github.com/apache/kafka/pull/355

Jun, we had discussed that we could do this after 0.9.0.0, but there are two 
reasons why I think we should do it before:

1. We claim that the variable names for config classes cannot be changed, I 
assume that means that we don't want to change the class name of `SSLConfigs` 
after the release.

2. This will make it easier to backport changes from trunk to the 0.9 branch 
after it's created.

> Fix capitalization in SSL classes
> ---------------------------------
>
>                 Key: KAFKA-2460
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2460
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.0
>            Reporter: Jay Kreps
>            Assignee: Ismael Juma
>            Priority: Minor
>
> I notice that all the SSL classes are using the convention SSLChannelBuilder, 
> SSLConfigs, etc. Kafka has always used the convention SslChannelBuilder, 
> SslConfigs, etc. See e.g. KafkaApis, ApiUtils, LeaderAndIsrRequest, 
> ClientIdAndTopic, etc.
> We should fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to