[ https://issues.apache.org/jira/browse/KAFKA-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961427#comment-14961427 ]
ASF GitHub Bot commented on KAFKA-2640: --------------------------------------- GitHub user fpj opened a pull request: https://github.com/apache/kafka/pull/324 KAFKA-2640: Add tests for ZK authentication I've added a couple of initial tests to verify the functionality. I've tested that the JAAS config file loads properly and SASL with DIGEST-MD5 works with ZooKeeper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fpj/kafka KAFKA-2640 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/324.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #324 ---- commit 6a1ca42c41f0e577e33bf92cdc6aa6ec3a8da237 Author: flavio junqueira <f...@apache.org> Date: 2015-10-12T21:55:10Z Initial pass, main code compiles commit afeafabdcefc2dd93f28ab5e23041be7ebe08f3b Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T12:10:43Z Changes to tests to accomodate the refactoring of ZkUtils. commit 66b116aace0990182d76b6591b50491f072b95cb Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T12:59:06Z Removed whitespaces. commit 36c3720c734c003d306af76846a5531d844fdfc3 Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T13:27:43Z KAFKA-2639: Added close() method to ZkUtils commit a7ae4337f93c194f56456bd3b96c2f874e248190 Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T13:49:21Z KAFKA-2639: Fixed PartitionAssignorTest commit 78ee23d52ec0b4163c510b581910a610cd343c89 Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T14:09:50Z KAFKA-2639: Fixed ReplicaManagerTest commit 2e888de090cf4b33a09e6184217191c3563aea9d Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T14:26:33Z KAFKA-2639: Fixed ZKPathTest commit b94fd4bba9b8a29b7bbab62c74a4214b74504704 Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T16:03:05Z KAFKA-2639: Made isSecure a parameter of the factory methods for ZkUtils commit bd46f61800a5e47e5d4c15df2c5721303bc4c65e Author: flavio junqueira <f...@apache.org> Date: 2015-10-13T16:49:05Z KAFKA-2639: Fixed KafkaConfigTest. commit 8c69f239a0bd255b0379d761970996f380b00cd6 Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T08:38:17Z KAFKA-2639: Removing config via KafkaConfig. commit 00a816957c85601af0b4434768174bd1de91fe34 Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T08:41:04Z KAFKA-2639: Removed whitespaces. commit 6b2fd2af854c9e762331391723286fe53c91f2b3 Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T11:36:25Z Adding initial configuration and support to set acls commit 311612f533a8378b7c922016e632c3b703acc844 Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T11:49:54Z KAFKA-2639: Removed unrelated comment from ZkUtils. commit f76c72a71fd386e2dfe2fb0351d07f2b9eca0bef Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T13:43:07Z KAFKA-2641: First cut at the ZK Security Migration Tool. commit fb9a52a5becf910981f7bc42634f96a047f5750b Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T15:12:55Z KAFKA-2639: Moved isSecure to JaasUtils in clients. commit 8314c7f4a91bca7b48c0909d46211ba1db6ecb3b Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T17:14:29Z KAFKA-2639: Covering more zk system properties. commit 76a802d612f531d0a36c3ceab8c2a1f8964b558b Author: flavio junqueira <f...@apache.org> Date: 2015-10-14T17:31:48Z KAFKA-2639: Small update to log message and exception message in JaasUtils. commit 45e39b6874e5082b659ad04c72cd693cf1bc26d8 Author: flavio junqueira <f...@apache.org> Date: 2015-10-15T08:41:37Z KAFKA-2641: Adding script and moving the tool to the admin package. commit 83e1dc545a72c762ff7ced24dd22cdcbb1204e74 Author: flavio junqueira <f...@apache.org> Date: 2015-10-15T08:51:02Z Merge branch 'KAFKA-2639' into KAFKA-2641 commit 02f1ae2d514bab264d561e606d652ecd7316d600 Author: flavio junqueira <f...@apache.org> Date: 2015-10-15T09:30:06Z Merge remote-tracking branch 'upstream/trunk' into KAFKA-2641 commit fd799b02dabc958da96d138d8f8791f8aa35cc70 Author: flavio junqueira <f...@apache.org> Date: 2015-10-15T09:35:39Z Merge remote-tracking branch 'upstream/trunk' into KAFKA-2639 commit cb0c751f01a65ac882a880185ec090b979ff6007 Author: flavio junqueira <f...@apache.org> Date: 2015-10-15T10:50:27Z KAFKA-2641: Polished migration tool code. commit 58e17b2d0a2d53c53050efc68cb83de7649b9ea2 Author: flavio junqueira <f...@apache.org> Date: 2015-10-15T12:06:11Z KAFKA-2639: create->apply and isSecure->isZkSecurityEnabled commit 943f30d428b2c6ddb1c731c91ae4e8b2e6b177c7 Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T08:54:51Z Merge branch 'KAFKA-2639' into KAFKA-2641 commit 3e9d11cbbdcb8edd67a013672489cf27d8d3dcaa Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T09:17:49Z KAFKA-2640: First test case along with conf file. commit 4a672033ad67299d5a9c9806198458a397b939aa Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T09:23:48Z KAFKA-2641: Fixed a couple of compilation issues with tests. commit 967ded176464eb9eada6051cb0ed7113438af0d0 Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T09:24:07Z Merge branch 'KAFKA-2641' into KAFKA-2640 commit 53ccead1f8300f18ccc46e1c959a87b4401fe07f Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T10:17:13Z KAFKA-2640: Initial test passes. commit 7a1c77d0aa3260f46d357b78ac981593982d62df Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T10:18:20Z KAFKA-2641: Fix bug in JaasUtils. commit c9cad9c49cd9dff44eef934966ad9f9c799bbd69 Author: flavio junqueira <f...@apache.org> Date: 2015-10-16T10:18:55Z Merge branch 'KAFKA-2641' into KAFKA-2640 ---- > Add tests for ZK authentication > ------------------------------- > > Key: KAFKA-2640 > URL: https://issues.apache.org/jira/browse/KAFKA-2640 > Project: Kafka > Issue Type: Sub-task > Components: security > Reporter: Flavio Junqueira > Assignee: Flavio Junqueira > > Add tests for KAKA-2639. -- This message was sent by Atlassian JIRA (v6.3.4#6332)