[
https://issues.apache.org/jira/browse/KAFKA-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959887#comment-14959887
]
ASF GitHub Bot commented on KAFKA-2338:
---------------------------------------
GitHub user benstopford opened a pull request:
https://github.com/apache/kafka/pull/322
KAFKA-2338: Warn on max.message.bytes change
- Both TopicCommand and ConfigCommand warn if message.max.bytes increases
- Log failures on the broker if replication gets stuck due to an oversized
message
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benstopford/kafka CPKAFKA-61
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit d59110d28fe1dcd62520e2b031005a369ceb4bc7
Author: benstopford <benstopf...@gmail.com>
Date: 2015-10-15T17:13:09Z
KAFKA-2338: Warn user if they override max.message.bytes. Warn on failing
replica fetches.
----
> Warn users if they change max.message.bytes that they also need to update
> broker and consumer settings
> ------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2338
> URL: https://issues.apache.org/jira/browse/KAFKA-2338
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8.2.1
> Reporter: Ewen Cheslack-Postava
> Assignee: Ben Stopford
> Priority: Critical
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2338.patch, KAFKA-2338_2015-07-18_00:37:31.patch,
> KAFKA-2338_2015-07-21_13:21:19.patch, KAFKA-2338_2015-08-24_14:32:38.patch,
> KAFKA-2338_2015-09-02_19:27:17.patch
>
>
> We already have KAFKA-1756 filed to more completely address this issue, but
> it is waiting for some other major changes to configs to completely protect
> users from this problem.
> This JIRA should address the low hanging fruit to at least warn users of the
> potential problems. Currently the only warning is in our documentation.
> 1. Generate a warning in the kafka-topics.sh tool when they change this
> setting on a topic to be larger than the default. This needs to be very
> obvious in the output.
> 2. Currently, the broker's replica fetcher isn't logging any useful error
> messages when replication can't succeed because a message size is too large.
> Logging an error here would allow users that get into a bad state to find out
> why it is happening more easily. (Consumers should already be logging a
> useful error message.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
