I agree with Guozhang. On Tue, Oct 6, 2015 at 5:49 PM, Gwen Shapira <g...@confluent.io> wrote:
> Agree with Guozhang. > > On Tue, Oct 6, 2015 at 3:22 PM, Guozhang Wang <wangg...@gmail.com> wrote: > > > I think github cannot batch comments in emails (yet?), which is sad.. > > > > I would prefer to keep both github@kafka / github@kafka-site to send > only > > open/close PRs unless you subscribe to some tickets. > > > > Guozhang > > > > On Tue, Oct 6, 2015 at 9:49 AM, Jiangjie Qin <j...@linkedin.com.invalid> > > wrote: > > > > > Hi Ismael, > > > > > > Thanks for bringing this up. Completely agree the exploding amount of > > > emails is a little annoying, regardless they are sent to dev list or > > > personal emails. > > > > > > Not sure whether it is doable or not, but here is what I am thinking. > > > 1. batch the comments email and send periodically to dev list or > project > > > subscribers. e.g. 4 hours a day. > > > 2. direct email the PR submitter/reviewers when comments are put. > > > > > > Not sure if github can do that or not. Maybe worth sending email to > ask. > > > > > > Thanks, > > > > > > Jiangjie (Becket) Qin > > > > > > > > > > > > On Tue, Oct 6, 2015 at 1:35 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > > Hi all, > > > > > > > > You may have noticed that we receive one email for each comment in > > > > kafka-site pull requests. We don't have that enabled for the kafka > (ie > > > > code) repository. Maybe that's OK as the number of emails would be > much > > > > higher for the code repository, but I thought it would be good to get > > > other > > > > people's opinions on it. > > > > > > > > So, for the code repository, would you prefer if: > > > > > > > > 1. We leave things as they are (emails to dev list are sent for > > > > opening/closing of PRs and other notifications are handled by one's > own > > > > GitHub notification settings) > > > > 2. We change it to be like kafka-site and an email is sent to the dev > > > list > > > > for each PR comment > > > > 3. Something else > > > > > > > > Ismael > > > > > > > > > > > > > > > -- > > -- Guozhang > > >
