GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/280

    Reduce logging level for controller connection failures from `error` to 
`warn`

    Before we switched from `BlockingChannel` to `NetworkClient`, we were
    always reporting a successful connection due to the fact that
    `BlockingChannel.connect` catches and swallows all exceptions. We
    are now reporting failures (which is better), but `error` seems too
    noisy (as can be seen in our tests).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka 
reduce-connection-failure-logging-level

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
    
----
commit ab58bf11d128c23413fe30d5a486b73493d5511f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2015-10-06T11:31:08Z

    Reduce logging level for controller connection failures from `error` to 
`warn`
    
    Before we switched from `BlockingChannel` to `NetworkClient`, we were
    always reporting a successful connection due to the fact that
    `BlockingChannel.connect` catches and swallows all exceptions. We
    are now reporting failures (which is better), but `error` seems too
    noisy (as can be seen in our tests).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to