[
https://issues.apache.org/jira/browse/KAFKA-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939097#comment-14939097
]
ASF GitHub Bot commented on KAFKA-2596:
---------------------------------------
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/267
KAFKA-2596: reject commits from unknown groups with positive generations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka KAFKA-2596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit 4dd1fa1705d5d6d77325db43049e1bb433817209
Author: Jason Gustafson <ja...@confluent.io>
Date: 2015-10-01T00:11:04Z
KAFKA-2596: reject commits from unknown groups with positive generations
----
> Coordinator should return illegal generation for commits from unknown groups
> with non-negative generation
> ---------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2596
> URL: https://issues.apache.org/jira/browse/KAFKA-2596
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.9.0.0
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
>
> Currently the consumer coordinator accepts offset commits blindly if it has
> no state stored for the associated groupId. This means that upon coordinator
> failover, offset commits from any member of a group will be accepted, even if
> that member is from an older generation. A better way of handling this case
> would be to return an ILLEGAL_GENERATION error when the generation in the
> commit request is greater than or equal to 0. Consumers that are not using
> group management will always send a generation of -1, so their commits will
> still be accepted as valid.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
