[ 
https://issues.apache.org/jira/browse/KAFKA-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909033#comment-14909033
 ] 

Ewen Cheslack-Postava commented on KAFKA-2581:
----------------------------------------------

Excellent, that's much better scoping than "everything". I have not looked 
closely enough at the SSL patches and I know you have a much better handle on 
what's useful to test -- if there's a case for replication_test breaking under 
SSL in ways it wouldn't under plaintext, I absolutely trust you to determine 
that :) It's definitely possible that *all* tests we have in ducktape now are 
useful to have SSL and non-SSL versions of simply because we only have a few 
tests!

One of the reasons I was trying to reduce the scope is that the approach to a 
patch for this is completely different if you want to test *everything* with 
SSL vs plaintext compared to just testing a small subset of tests with SSL 
enabled/disabled. If you really want to test everything with SSL on/off, then 
we'd want a ducktape mechanism to help with global switches. In contrast, if we 
just want to parameterize a certain set of tests (which might currently, but 
not always, be all tests), then we probably just need an SSL flag on the 
KafkaService class and @parametrize annotations on a few tests.

I'm obviously all for adding system tests where it makes sense, but I want to 
be judicious when adding them because each one is relatively expensive.

> Run all existing ducktape tests with SSL-enabled clients and brokers
> --------------------------------------------------------------------
>
>                 Key: KAFKA-2581
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2581
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 0.9.0.0
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>             Fix For: 0.9.0.0
>
>
> New ducktape tests for testing SSL are being added under KAFKA-2417. This 
> task will enable existing ducktape tests to be run with SSL-enabled brokers 
> and clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to