[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803338#comment-14803338
]
Mayuresh Gharat edited comment on KAFKA-2120 at 9/17/15 6:18 PM:
-----------------------------------------------------------------
"Looking at the code, I noticed that we are passing the request timeout for the
broker code (ControllerChannelManager, KafkaServer and
`ReplicaFetcherThread`)". This might be true, I am not sure because anything
that uses NetworkClient will use the new configured requestTimeout for sent
requests.
Also since both me and Joel saw failures with earlier commits, I am not sure if
they existed with earlier commits and this patch is making them more prominent.
Thanks,
Mayuresh
was (Author: mgharat):
"Looking at the code, I noticed that we are passing the request timeout for the
broker code (ControllerChannelManager, KafkaServer and
`ReplicaFetcherThread`)". This might be true, I am not sure because anything
that uses NetworkClient will use the new configured requestTimeout for sent
requests.
Also both me and Joel saw failures with earlier commits, I am not sure if they
existed with earlier commits and this patch is making them more prominent.
Thanks,
Mayuresh
> Add a request timeout to NetworkClient
> --------------------------------------
>
> Key: KAFKA-2120
> URL: https://issues.apache.org/jira/browse/KAFKA-2120
> Project: Kafka
> Issue Type: New Feature
> Reporter: Jiangjie Qin
> Assignee: Mayuresh Gharat
> Priority: Blocker
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2120.patch, KAFKA-2120_2015-07-27_15:31:19.patch,
> KAFKA-2120_2015-07-29_15:57:02.patch, KAFKA-2120_2015-08-10_19:55:18.patch,
> KAFKA-2120_2015-08-12_10:59:09.patch, KAFKA-2120_2015-09-03_15:12:02.patch,
> KAFKA-2120_2015-09-04_17:49:01.patch, KAFKA-2120_2015-09-09_16:45:44.patch,
> KAFKA-2120_2015-09-09_18:56:18.patch, KAFKA-2120_2015-09-10_21:38:55.patch,
> KAFKA-2120_2015-09-11_14:54:15.patch, KAFKA-2120_2015-09-15_18:57:20.patch
>
>
> Currently NetworkClient does not have a timeout setting for requests. So if
> no response is received for a request due to reasons such as broker is down,
> the request will never be completed.
> Request timeout will also be used as implicit timeout for some methods such
> as KafkaProducer.flush() and kafkaProducer.close().
> KIP-19 is created for this public interface change.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-19+-+Add+a+request+timeout+to+NetworkClient
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
