[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742546#comment-14742546 ]
ASF GitHub Bot commented on KAFKA-1901: --------------------------------------- GitHub user omkreddy opened a pull request: https://github.com/apache/kafka/pull/209 KAFKA-1901: follow-up on KAFKA-1901; Added error handling. @guozhangwang added .git/refs/heads/ file existence check. You can merge this pull request into a Git repository by running: $ git pull https://github.com/omkreddy/kafka KAFKA-1901 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #209 ---- ---- > Move Kafka version to be generated in code by build (instead of in manifest) > ---------------------------------------------------------------------------- > > Key: KAFKA-1901 > URL: https://issues.apache.org/jira/browse/KAFKA-1901 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8.2.0 > Reporter: Jason Rosenberg > Assignee: Manikumar Reddy > Fix For: 0.9.0.0 > > Attachments: KAFKA-1901.patch, KAFKA-1901_2015-06-26_13:16:29.patch, > KAFKA-1901_2015-07-10_16:42:53.patch, KAFKA-1901_2015-07-14_17:59:56.patch, > KAFKA-1901_2015-08-09_15:04:39.patch, KAFKA-1901_2015-08-20_12:35:00.patch > > > With 0.8.2 (rc2), I've started seeing this warning in the logs of apps > deployed to our staging (both server and client): > {code} > 2015-01-23 00:55:25,273 WARN [async-message-sender-0] common.AppInfo$ - > Can't read Kafka version from MANIFEST.MF. Possible cause: > java.lang.NullPointerException > {code} > The issues is that in our deployment, apps are deployed with single 'shaded' > jars (e.g. using the maven shade plugin). This means the MANIFEST.MF file > won't have a kafka version. Instead, suggest the kafka build generate the > proper version in code, as part of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)