[ 
https://issues.apache.org/jira/browse/KAFKA-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733888#comment-14733888
 ] 

Jiangjie Qin commented on KAFKA-2523:
-------------------------------------

[~jkreps], I have created KAFKA-2512 to add version check on both broker and 
clients. I have a patch ready and it seems not a big change to have the version 
check added cross board. Should we close this ticket as a duplicate? Or do you 
want to take the new consumer part out separately in this ticket? 

> New consumer doesn't check magic version
> ----------------------------------------
>
>                 Key: KAFKA-2523
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2523
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jay Kreps
>            Priority: Blocker
>
> The new consumer should be checking that messages it reads are in the format 
> it expects (and give a sane error message otherwise) rather than just 
> randomly reading other formats and running out of memory or getting cryptic 
> errors. This should be a one-line fix.
> It is important if we're thinking of changing the message format since you 
> need the proper check in the versions BEFORE the version where you make the 
> change so sane errors occur when the change eventually does happen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to