> On Sept. 2, 2015, 1:11 p.m., Ismael Juma wrote: > > Hi Parth, I finally had a bit of time to look into this in more detail and > > I pushed a commit with my suggestions to make the `KafkaApis` code a bit > > more readable: > > > > https://github.com/ijuma/kafka/commit/7737a9feb0c6d8cb4be3fe22992f8dc10b657154 > > > > As you said, it's difficult to do much better given the lack of common > > interfaces. > > > > Please incorporate the changes if you agree. Also, note that I added a > > FIXME in one case where we don't seem to use the data produced by the > > `partition` call.
Cherry picked. The FIXME does not need any change if you see https://github.com/Parth-Brahmbhatt/kafka/blob/az/core/src/main/scala/kafka/server/KafkaApis.scala#L195 it uses unauthorized partiton in constructing respoinse. where as the authorized part gets used https://github.com/Parth-Brahmbhatt/kafka/blob/az/core/src/main/scala/kafka/server/KafkaApis.scala#L214 and https://github.com/Parth-Brahmbhatt/kafka/blob/az/core/src/main/scala/kafka/server/KafkaApis.scala#L255 and the actual call back finally gets called here https://github.com/Parth-Brahmbhatt/kafka/blob/az/core/src/main/scala/kafka/server/KafkaApis.scala#L273. - Parth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review97432 ----------------------------------------------------------- On Sept. 3, 2015, 12:36 a.m., Parth Brahmbhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34492/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 12:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2210 > https://issues.apache.org/jira/browse/KAFKA-2210 > > > Repository: kafka > > > Description > ------- > > Addressing review comments from Jun. > > > Adding CREATE check for offset topic only if the topic does not exist already. > > > Addressing some more comments. > > > Removing acl.json file > > > Moving PermissionType to trait instead of enum. Following the convention for > defining constants. > > > Adding authorizer.config.path back. > > > Addressing more comments from Jun. > > > Addressing more comments. > > > Now addressing Ismael's comments. Case sensitive checks. > > > Addressing Jun's comments. > > > Merge remote-tracking branch 'origin/trunk' into az > > Conflicts: > core/src/main/scala/kafka/server/KafkaApis.scala > core/src/main/scala/kafka/server/KafkaServer.scala > > Deleting KafkaConfigDefTest > > > Addressing comments from Ismael. > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into az > > > Consolidating KafkaPrincipal. > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into az > > Conflicts: > > clients/src/main/java/org/apache/kafka/common/network/PlaintextTransportLayer.java > > clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java > core/src/main/scala/kafka/server/KafkaApis.scala > > Making Acl structure take only one principal, operation and host. > > > Merge remote-tracking branch 'origin/trunk' into az > > > Reverting uninteded new line change. > > > Addressing comments from Jun. > > > Merge remote-tracking branch 'origin/trunk' into az > > > Various tweaks that make the code more readable > > Conflicts: > core/src/main/scala/kafka/server/KafkaApis.scala > > Fixing compilation errors after cherry-pocking. > > > Removing FIXME. > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/network/PlaintextTransportLayer.java > 35d41685dd178bbdf77b2476e03ad51fc4adcbb6 > clients/src/main/java/org/apache/kafka/common/protocol/Errors.java > 641afa1b2474150fa1002e9fedca13ff55175a7e > > clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipal.java > b640ea0f4bdb694fc5524ef594aa125cc1ba4cf3 > > clients/src/test/java/org/apache/kafka/common/security/auth/KafkaPrincipalTest.java > PRE-CREATION > core/src/main/scala/kafka/api/OffsetRequest.scala > f418868046f7c99aefdccd9956541a0cb72b1500 > core/src/main/scala/kafka/common/AuthorizationException.scala PRE-CREATION > core/src/main/scala/kafka/common/ErrorMapping.scala > c75c68589681b2c9d6eba2b440ce5e58cddf6370 > core/src/main/scala/kafka/security/auth/Acl.scala PRE-CREATION > core/src/main/scala/kafka/security/auth/Authorizer.scala PRE-CREATION > core/src/main/scala/kafka/security/auth/Operation.scala PRE-CREATION > core/src/main/scala/kafka/security/auth/PermissionType.scala PRE-CREATION > core/src/main/scala/kafka/security/auth/Resource.scala PRE-CREATION > core/src/main/scala/kafka/security/auth/ResourceType.scala PRE-CREATION > core/src/main/scala/kafka/server/KafkaApis.scala > a3a8df0545c3f9390e0e04b8d2fab0134f5fd019 > core/src/main/scala/kafka/server/KafkaConfig.scala > d547a01cf7098f216a3775e1e1901c5794e1b24c > core/src/main/scala/kafka/server/KafkaServer.scala > 756cf775cadbcaf01df7f691d8d01d9ff75db291 > core/src/test/scala/unit/kafka/security/auth/AclTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/security/auth/OperationTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/security/auth/PermissionTypeTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/security/auth/ResourceTypeTest.scala > PRE-CREATION > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 3da666f73227fc7ef7093e3790546344065f6825 > > Diff: https://reviews.apache.org/r/34492/diff/ > > > Testing > ------- > > > Thanks, > > Parth Brahmbhatt > >
