[ 
https://issues.apache.org/jira/browse/KAFKA-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717815#comment-14717815
 ] 

ASF GitHub Bot commented on KAFKA-2485:
---------------------------------------

GitHub user lindong28 opened a pull request:

    https://github.com/apache/kafka/pull/174

    KAFKA-2485; Allow producer performance to take properties from a file…

    … via --consumer.config command line parameter

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lindong28/kafka KAFKA-2485

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit b612b17a97e86a9ed7b6405ff3151f9e00f49d1f
Author: Dong Lin <lindon...@gmail.com>
Date:   2015-08-28T00:10:10Z

    KAFKA-2485; Allow producer performance to take properties from a file via 
--consumer.config command line parameter

----


> Allow producer performance to take properties from a file via 
> --consumer.config command line parameter
> ------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-2485
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2485
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Dong Lin
>            Assignee: Dong Lin
>
> In order to allow ProducerPerformance to produce via ssl connection, we need 
> the following (example) configuration:
> security.protocol=SSL
> ssl.protocol=TLS
> ssl.truststore.type=JKS
> ssl.truststore.location=serverkeystore.jks
> ssl.truststore.password=password
> ssl.keymanager.algorithm=SunX509
> ssl.trustmanager.algorithm=SunX509
> There are two ways to achieve it: 1) extend ProducerPerformance to explicitly 
> accept all 7 ssl-related parameters; 2) allow ProducerPerformance to take 
> properties from a file via --consumer.config command line parameter.
> It seems option 2) is better, because it requires less code, allows new 
> options to be easily added in the future, and doesn't require user to specify 
> password in the command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to