[
https://issues.apache.org/jira/browse/KAFKA-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709881#comment-14709881
]
Grayson Chao commented on KAFKA-2412:
-------------------------------------
1. Good point. I agree that pointing toward the default implementations is
clear enough, since serialization is likely to be familiar to anybody who's
using Kafka anyway.
2. Rephrased the explanation of "in-flight requests" to make it more clear what
term is being defined. I can see why that was ambiguous before.
Regarding controlling batching behavior with linger.ms, it seems like
increasing the number could cause suboptimal batching unless the user
specifically sets linger.ms. If the max number of inflight requests is very
high or unlimited, then the batch size is basically (number of enqueued
requests per ms * linger.ms). Since linger.ms defaults to 0, batch size will
end up being very small. I've added a pointer to linger.ms in the explanation
for max.in.flight to address that.
I've also added the warning you mentioned about out-of-order arrivals, though I
don't understand why that happens. Is there an issue I can read so that I can
give a more detailed explanation (or is a more detailed explanation even
appropriate?)
If the explanation of the out-of-order arrivals is not necessary, I've got a
new diff ready that addresses all of your comments, otherwise I will add a more
detailed explanation and then submit it.
Thanks for your feedback! It's very much appreciated.
Grayson
> Documentation bug: Add information for key.serializer and value.serializer to
> New Producer Config sections
> ----------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-2412
> URL: https://issues.apache.org/jira/browse/KAFKA-2412
> Project: Kafka
> Issue Type: Bug
> Reporter: Jeremy Fields
> Assignee: Grayson Chao
> Priority: Minor
> Labels: newbie
> Attachments: KAFKA-2412.diff
>
>
> As key.serializer and value.serializer are required options when using the
> new producer, they should be mentioned in the documentation ( here and svn
> http://kafka.apache.org/documentation.html#newproducerconfigs )
> Appropriate values for these options exist in javadoc and producer.java
> examples; however, not everyone is reading those, as is the case for anyone
> setting up a producer.config file for mirrormaker.
> A sensible default should be suggested, such as
> org.apache.kafka.common.serialization.StringSerializer
> Or at least a mention of the key.serializer and value.serializer options
> along with a link to javadoc
> Thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
