[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708577#comment-14708577
]
Jason Gustafson edited comment on KAFKA-2389 at 8/23/15 10:42 PM:
------------------------------------------------------------------
+1 This suggestion has nice symmetry. Passing null as an argument always leaves
a bad taste, but if users are trying to manage commits manually, then they
probably should be providing the callback, so this forces them to make a
conscious decision not to.
was (Author: hachikuji):
+1 This suggestion has nice symmetry. Passing null as an argument always leaves
a bad taste, but if they are trying to manage commits manually, then they
probably should be providing the callback, so this forces them to make a
conscious decision not to.
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
