[ 
https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706128#comment-14706128
 ] 

ASF GitHub Bot commented on KAFKA-1566:
---------------------------------------

GitHub user harshach opened a pull request:

    https://github.com/apache/kafka/pull/156

    KAFKA-1566: Kafka environment configuration (kafka-env.sh)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/harshach/kafka KAFKA-1566

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 42b0acdb392494984b6928d94f0c611d4e1925de
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-01-08T15:50:20Z

    KAFKA-1566. Kafka environment configuration (kafka-env.sh).

commit 31d0dcab655b37864c207a08d5c77b9d27fff7bc
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-03-18T00:14:41Z

    KAFKA-1566. Kafka environment configuration (kafka-env.sh).

----


> Kafka environment configuration (kafka-env.sh)
> ----------------------------------------------
>
>                 Key: KAFKA-1566
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1566
>             Project: Kafka
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Cosmin Lehene
>            Assignee: Sriharsha Chintalapani
>              Labels: newbie
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1566.patch, KAFKA-1566_2015-02-21_21:57:02.patch, 
> KAFKA-1566_2015-03-17_17:01:38.patch, KAFKA-1566_2015-03-17_17:19:23.patch
>
>
> It would be useful (especially for automated deployments) to have an 
> environment configuration file that could be sourced from the launcher files 
> (e.g. kafka-run-server.sh). 
> This is how this could look like kafka-env.sh 
> {code}
> export KAFKA_JVM_PERFORMANCE_OPTS="-XX:+UseCompressedOops 
> -XX:+DisableExplicitGC -Djava.awt.headless=true \ -XX:+UseG1GC 
> -XX:PermSize=48m -XX:MaxPermSize=48m -XX:MaxGCPauseMillis=20 
> -XX:InitiatingHeapOccupancyPercent=35' %>" 
> export KAFKA_HEAP_OPTS="'-Xmx1G -Xms1G' %>" 
> export KAFKA_LOG4J_OPTS="-Dkafka.logs.dir=/var/log/kafka" 
> {code} 
> kafka-server-start.sh 
> {code} 
> ... 
> source $base_dir/config/kafka-env.sh 
> ... 
> {code} 
> This approach is consistent with Hadoop and HBase. However the idea here is 
> to be able to set these values in a single place without having to edit 
> startup scripts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to