[ 
https://issues.apache.org/jira/browse/KAFKA-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697401#comment-14697401
 ] 

ASF GitHub Bot commented on KAFKA-2221:
---------------------------------------

GitHub user jaikiran opened a pull request:

    https://github.com/apache/kafka/pull/138

    Log the real exception which triggered a reconnect

    The commit here improves the logging in SimpleConsumer to log the real 
reason why a reconnect was attempted. Relates to 
https://issues.apache.org/jira/browse/KAFKA-2221.
    
    The same patch was submitted a while back but wasn't merged because 
SimpleConsumer was considered deprecated and users' aren't expected to use it. 
However, more and more users in the user mailing list are running into this log 
message but have no way to understand what the root cause is. So IMO, this 
change still adds value  to such users who are using SimpleConsumer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaikiran/kafka kafka-2221

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit 4fb024931761d253ae110cfa69377508de4a1f61
Author: Jaikiran Pai <jaikiran....@gmail.com>
Date:   2015-08-14T16:58:57Z

    Log the real exception which triggered a reconnect

----


> Log the entire cause which caused a reconnect in the SimpleConsumer
> -------------------------------------------------------------------
>
>                 Key: KAFKA-2221
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2221
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: jaikiran pai
>            Assignee: jaikiran pai
>            Priority: Minor
>         Attachments: KAFKA-2221.patch
>
>
> Currently if the SimpleConsumer goes for a reconnect, it logs the exception's 
> message which caused the reconnect. However, in some occasions the message in 
> the exception can be null, thus making it difficult to narrow down the cause 
> for the reconnect. An example of this can be seen in this user mailing list 
> thread 
> http://mail-archives.apache.org/mod_mbox/kafka-users/201505.mbox/%3CCABME_6T%2Bt90%2B-eQUtnu6R99NqRdMpVj3tqa95Pygg8KOQSNppw%40mail.gmail.com%3E
> {quote}
> kafka.consumer.SimpleConsumer: Reconnect due to socket error: null.
> {quote}
> It would help narrowing down the problem if the entire exception stacktrace 
> was logged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to