Good question. I can personally think of pros and cons of having a volunteer list, most of them are pros but one con is that the list will never be comprehensive and in that sense sort of discouraging people to assign themselves as the reviewer.
Without such a list, contributors would most likely assign reviewers to who they saw to have been a reviewer before or who they know of (i.e. a committer most of times). But we could try to encourage people re-assign review roles to who they think would be comfortable to do so (maybe they have contributed multiple patches on that module, or they have participated discussions in that topic, or they are known to have the background, etc), while at the same time encourage people to (re-)assign reviewer to themselves, and hope that over time more people to be observed as the "reviewers to go to". This may also help the community to grow committers. Thoughts? Guozhang On Tue, Aug 11, 2015 at 1:50 PM, Grant Henke <ghe...@cloudera.com> wrote: > > > > 2. Encourage contributors to set the "reviewer" field when change JIRA > > status to "patch available", and encourage volunteers assigning > themselves > > to "reviewers" for pending tickets. > > > Is there somewhere that describes who to pick as a reviewer based on the > patch? Would it be worth listing volunteer reviews in a similar location? > > On Tue, Aug 11, 2015 at 2:14 PM, Guozhang Wang <wangg...@gmail.com> wrote: > > > First of all, WebEx seems working! And we will upload the recorded video > > later. > > > > Quick summary: > > > > KIP-26: RP-99 (https://github.com/apache/kafka/pull/99) pending for > > reviews. > > > > KIP-28: RP-130 (https://github.com/apache/kafka/pull/130) looking for > > feedbacks on: > > > > 1. API design (see o.k.a.stream.examples). > > 2. Architecture design (see KIP wiki page) > > 3. Packaging options. > > > > KIP-29: we will do a quick fix for unblocking production issues with > > hard-coded interval values, while at the same time keep the KIP open for > > further discussions about end state configurations. > > > > KIP-4: KAFKA-1695 / 2210 pending for reviews. > > > > Review Backlog Management: > > > > 1. Remind people to change JIRA status as "patch available" when they > > contribute the patch, and change the status back to "in progress" after > it > > is reviewed, as indicated in: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > > > > 2. Encourage contributors to set the "reviewer" field when change JIRA > > status to "patch available", and encourage volunteers assigning > themselves > > to "reviewers" for pending tickets. > > > > -- Guozhang > > > > > > -- > Grant Henke > Software Engineer | Cloudera > gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke > -- -- Guozhang
