[ 
https://issues.apache.org/jira/browse/KAFKA-2071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662025#comment-14662025
 ] 

David Jacot commented on KAFKA-2071:
------------------------------------

I have looked at the producer and I think that migrating it to the new Request 
/ Response is doable. The only annoying thing is that everything goes through 
the SyncProducer.doSend method which takes RequestOrResponse objects as 
argument. I'm a bit concern by migrating only the Produce Request/Response 
alone as it will require some code duplication in the SyncProducer to support 
both new and old kind of requests. The producer only uses ProducerRequest and 
TopicMetadataRequest, so I'm wondering if addressing both of them in a separate 
Jira wouldn't better (or at least less error prone). It will allow to migrate 
the SyncProducer entirely at once.

I would propose following strategy:
1. We get migration of Produce Request/Response of server part in.
2. We get migration of TopicMetadata Request/Response of server part in as well.
3. We adresse the producer by migrating both and them we can remove all 
request/response.

WDYT?

> Replace Produce Request/Response with their org.apache.kafka.common.requests 
> equivalents
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-2071
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2071
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Gwen Shapira
>            Assignee: David Jacot
>             Fix For: 0.8.3
>
>
> Replace Produce Request/Response with their org.apache.kafka.common.requests 
> equivalents



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to