[
https://issues.apache.org/jira/browse/KAFKA-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654481#comment-14654481
]
ASF GitHub Bot commented on KAFKA-2405:
---------------------------------------
GitHub user jaikiran opened a pull request:
https://github.com/apache/kafka/pull/111
KAFKA-2405 Don't kill the JVM on session establishment failure
As noted in the JIRA https://issues.apache.org/jira/browse/KAFKA-2405
currently the KafkaHealthCheck causes the JVM to terminate in cases where
session establishment with Zookeeper fails. I don't know if retrying (after a
while) is a better way to fix this but at least, IMO, the session establishment
failure shouldn't kill the JVM. This commit removes the `System.exit()` call.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/kafka kafka-2405
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit f809162fcaf6cba9eddbc33dd4349ea453a1d8d8
Author: Jaikiran Pai <jaikiran....@gmail.com>
Date: 2015-08-04T22:36:40Z
KAFKA-2405 Don't kill the JVM on session establishment failure
----
> KafkaHealthCheck kills the JVM in handleSessionEstablishmentError
> -----------------------------------------------------------------
>
> Key: KAFKA-2405
> URL: https://issues.apache.org/jira/browse/KAFKA-2405
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: jaikiran pai
> Assignee: jaikiran pai
>
> The current code in KafkaHealthCheck in trunk does this:
> {code}
> override def handleSessionEstablishmentError(error: Throwable): Unit = {
> fatal("Could not establish session with zookeeper", error)
> System.exit(-1)
> }
> {code}
> thus terminating the JVM. A session establishment error shouldn't cause the
> JVM to terminate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
