[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654462#comment-14654462
]
Jun Rao commented on KAFKA-2205:
--------------------------------
[~aauradkar], the latest patch looks good overall. I hit the following unit
test failure. Since it's a trivial fix, I fixed it and then committed the patch.
kafka.admin.ConfigCommandTest > testArgumentParse FAILED
java.lang.IllegalArgumentException: --entity-type must be 'topic' or
'client'
at
kafka.admin.ConfigCommand$ConfigCommandOptions.checkArgs(ConfigCommand.scala:169)
at
kafka.admin.ConfigCommandTest.testArgumentParse(ConfigCommandTest.scala:38)
A couple of other things.
1. Currently, if I add client config and then remove it, the clientid still
shows up during describe, but with empty config values. We probably should
delete the path when there is no overwritten values. Could you do that in a
follow up patch?
bin/kafka-configs.sh --zookeeper localhost:2181 --entity-type client --describe
Configs for client:client1 are
2. Could you document the ZK path change in
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper
?
> Generalize TopicConfigManager to handle multiple entity configs
> ---------------------------------------------------------------
>
> Key: KAFKA-2205
> URL: https://issues.apache.org/jira/browse/KAFKA-2205
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Aditya Auradkar
> Assignee: Aditya Auradkar
> Labels: quotas
> Attachments: KAFKA-2205.patch, KAFKA-2205_2015-07-01_18:38:18.patch,
> KAFKA-2205_2015-07-07_19:12:15.patch, KAFKA-2205_2015-07-14_10:33:47.patch,
> KAFKA-2205_2015-07-14_10:36:36.patch, KAFKA-2205_2015-07-17_11:14:26.patch,
> KAFKA-2205_2015-07-17_11:18:31.patch, KAFKA-2205_2015-07-24_18:11:34.patch
>
>
> Acceptance Criteria:
> - TopicConfigManager should be generalized to handle Topic and Client configs
> (and any type of config in the future). As described in KIP-21
> - Add a ConfigCommand tool to change topic and client configuration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
